This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evdokimovs
added
feature
New feature or request
k::api
Related to API (application interface)
labels
Dec 12, 2019
FCM
|
FCM
|
alexlapa
suggested changes
Jan 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evdokimovs ,
LGTM.
Retest, update FCM. If everything is ok, then send to tyranron.
tyranron
approved these changes
Jan 16, 2020
evdokimovs
changed the title
WIP: Jason WebSocket reconnection (#47)
Jason WebSocket reconnection (#47)
Jan 16, 2020
tyranron
added
enhancement
Improvement of existing features or bugfix
k::design
Related to overall design and/or architecture
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
labels
Jan 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
Improvement of existing features or bugfix
feature
New feature or request
k::api
Related to API (application interface)
k::design
Related to overall design and/or architecture
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #47
Required for #51
Synopsis
Currently, when connection between server and client is lost, nothing happen. But we need mechanism of reconnection with some deadline and delay between reconnection tries.
Note that in this PR will be implemented only WebSocket reconnection without state synchronization. Synchronization of the Jason state will be implemented in #51.
Solution
Event::RpcSettingsUpdated
withidle_timeout
andreconnection_timeout
from a serverRpcTransport
RpcClient
RpcClient
reconnection triesRpcClient
reconnection (which will be calculated based onEvent::RpcSettingsUpdated
)Checklist
WIP:
prefixk::
labels appliedWIP:
prefix is removed