Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpki and ring-xous dependency #228

Merged
merged 8 commits into from
Nov 22, 2023

Conversation

Kailai-Wang
Copy link
Contributor

@Kailai-Wang Kailai-Wang commented Nov 17, 2023

Pretty much a copy-up of litentry/litentry-parachain#2229, with additional adjustments of error types and scale-info crate update.

If we need to use the pallets in no-std, we need to override the ring crate, like here:

[patch.crates-io]
ring = { git = "https://github.com/betrusted-io/ring-xous", branch = "0.16.20-cleanup" }

@clangenb
Copy link
Contributor

@Kailai-Wang master has the fix for the subxt test now, feel free to update your branch.

@Kailai-Wang
Copy link
Contributor Author

@Kailai-Wang master has the fix for the subxt test now, feel free to update your branch.

Thanks, I updated it. It should be ready for review now.

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good, except for one fundamental question, I have only one comment. Otherwise, I like the change, it makes the code more readable, and I also like that we can get rid of our fork.

You only need to fix the toml-fmt, and I would like to ask you to mention the patch in the readme. Thanks a lot for the contribution!

teerex/Cargo.toml Show resolved Hide resolved
teerex/sgx-verify/src/lib.rs Show resolved Hide resolved
teerex/sgx-verify/src/lib.rs Show resolved Hide resolved
@Kailai-Wang
Copy link
Contributor Author

Nice, looks good, except for one fundamental question, I have only one comment. Otherwise, I like the change, it makes the code more readable, and I also like that we can get rid of our fork.

You only need to fix the toml-fmt, and I would like to ask you to mention the patch in the readme. Thanks a lot for the contribution!

Thanks, I fixed that!
If you are happy with the text/position in README, please feel free to adjust it

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@clangenb clangenb merged commit 9fba4e2 into integritee-network:master Nov 22, 2023
11 checks passed
@Kailai-Wang Kailai-Wang deleted the update-webpki branch November 22, 2023 23:41
@brenzi
Copy link
Contributor

brenzi commented Dec 15, 2023

this causes trouble when I try to integrate it, even with the suggested patch:
image

smells like some missing std feature flag propagation

@brenzi
Copy link
Contributor

brenzi commented Dec 16, 2023

copying the Cargo.lock file from litentry fixed the mentioned issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants