-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webpki
and ring-xous
dependency
#228
Conversation
@Kailai-Wang master has the fix for the subxt test now, feel free to update your branch. |
Thanks, I updated it. It should be ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good, except for one fundamental question, I have only one comment. Otherwise, I like the change, it makes the code more readable, and I also like that we can get rid of our fork.
You only need to fix the toml-fmt, and I would like to ask you to mention the patch in the readme. Thanks a lot for the contribution!
Thanks, I fixed that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me!
copying the Cargo.lock file from litentry fixed the mentioned issue |
Pretty much a copy-up of litentry/litentry-parachain#2229, with additional adjustments of error types and
scale-info
crate update.If we need to use the pallets in no-std, we need to override the
ring
crate, like here: