Add CompilationDatabase class #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encapsulates a collection of CompileCommand objects and provides methods to simplify creation of databases from JSON. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Primarily used now for defining CompilationDatabase tests, but may also be useful later to detect/prune duplicated commands. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
laserkelvin
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Progress towards #100.
Proposed changes
CompilationDatabaseclass encapsulating a list ofCompileCommandobjects.CompilationDatabasefunctionality.CompileCommandobjects with aCompilationDatabase.This may look like a lot of work for very little payoff, but that's because this is only the first step in the refactoring. This PR introduces and uses
CompilationDatabaseto replace a list ofCompileCommandobjects during the construction of the legacyconfigurationdictionary, but stops short of removing theconfigurationdictionary itself.