Write logs to cbi.log by default #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to call logging.getLogger("codebasin") each time we use
the logger; we can adopt the convention used by other parts of the code.
Signed-off-by: John Pennycook <john.pennycook@intel.com>
- All messages are written to a log file ("cbi.log")
- Only errors are written to the terminal by default
- Messages written to terminal are based on -q and -v flags
Signed-off-by: John Pennycook <john.pennycook@intel.com>
laserkelvin
reviewed
Sep 24, 2024
| file_handler.setFormatter(formatter) | ||
| log.addHandler(file_handler) | ||
| log_path = os.path.realpath("cbi.log") | ||
| print(f"Log file created at {log_path}") |
There was a problem hiding this comment.
Can you not just log this after you've set up the stdout handler?
| @@ -243,5 +257,5 @@ def report_enabled(name): | |||
| sys.argv[0] = "codebasin" | |||
| main() | |||
| except Exception as e: | |||
| logging.getLogger("codebasin").error(str(e)) | |||
| log.error(str(e)) | |||
There was a problem hiding this comment.
Is this purposefully done to not include the traceback? Otherwise you can do log.exception(e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
First part of the solution to #108. I'll open a separate PR with my proposed
WarningAggregatorclass once this is merged.Proposed changes
ERRORtoWARNING, so that warnings are not printed to the terminal by default.