Replace FileLanguage class with a Language enum #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pennycook
commented
Jan 29, 2024
Pennycook
commented
- Avoids referencing languages by name (as strings).
- Enables multiple constructors (from_path and from_ext).
- Enables a dedicated sentinel value (UNKNOWN) instead of None.
- Avoids referencing languages by name (as strings). - Enables multiple constructors (from_path and from_ext). - Enables a dedicated sentinel value (UNKNOWN) instead of None. Signed-off-by: John Pennycook <john.pennycook@intel.com>
We can convert None into Language.UNKNOWN automatically, so there is no need to break downstream users of these functions. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Pennycook
added
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.