Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if codebase section exists in analysis file #75

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Check if codebase section exists in analysis file #75

merged 1 commit into from
Mar 5, 2024

Conversation

Pennycook
Copy link
Contributor

Previously we assumed it was present, even though it is optional.

Related issues

Fixes #71.

Proposed changes

  • Check if "codebase" exists in the analysis TOML before trying to use it as a key.
  • Skip codebase-level configuration (e.g., excludes) if "codebase" is not present.

@Pennycook
Check if codebase section exists in analysis file
c42c7b1 
Previously we assumed it was present, even though it is optional.

Signed-off-by: John Pennycook <john.pennycook@intel.com>
@Pennycook Pennycook added the bug Something isn't working label Mar 5, 2024
@Pennycook Pennycook added this to the 1.2.0 milestone Mar 5, 2024
@Pennycook Pennycook merged commit 1a6dce2 into intel:main Mar 5, 2024
2 checks passed
@Pennycook Pennycook deleted the optional-codebase-section branch March 5, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laserkelvin laserkelvin laserkelvin approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Analysis TOML file requires "codebase" section
2 participants
@Pennycook @laserkelvin