Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify platform option #76

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Simplify platform option #76

merged 3 commits into from
Mar 12, 2024

Commits on Mar 6, 2024

  1. Simplify --platform (-p) option 

    After internal testing and review, we reached the conclusion that using -p to
both define and filter platforms was too confusing and difficult to teach.
Additionally, there are concerns that use of flags to define platforms may not
scale, since real-life use-cases may require more than a list of commands.

This commit is a partial revert of intel#49: the ability to filter platforms
remains, but the ability to define platforms directly via JSON is removed.

Signed-off-by: John Pennycook <john.pennycook@intel.com>
    @Pennycook
    Pennycook committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0ca263e View commit details
    Browse the repository at this point in the history

  2. Throw error if platform passed to -p doesn't exist 

    Signed-off-by: John Pennycook <john.pennycook@intel.com>
    @Pennycook
    Pennycook committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4cadabe View commit details
    Browse the repository at this point in the history

  3. Add platforms from TOML file to codebase platforms 

    Signed-off-by: John Pennycook <john.pennycook@intel.com>
    @Pennycook
    Pennycook committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    a09cbe6 View commit details
    Browse the repository at this point in the history