Remove --source-dir (-S) option #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are contemplating adding support for per-platform source directories in a future release. Adding such functionality would make the -S flag harder to understand, as some users may expect to be able to specify -S multiple times. To avoid being stuck supporting -S after 1.2.0, remove it for now. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Pennycook
force-pushed
the
remove-source-option
branch
from
433aa42
to
8fffc50
Compare
laserkelvin
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are contemplating adding support for per-platform source directories in a future release. Adding such functionality would make the
-Sflag harder to understand, as some users may expect to be able to specify-Smultiple times.To avoid being stuck supporting
-Safter 1.2.0, remove it for now.Related issues
N/A
Proposed changes
-Sfrom argument parser.--source-dirand-S.