Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --root-dir option #90

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

Pennycook
Copy link
Contributor

This functionality was previously deprecated in 1.2.0.

This commit does not remove the concept of a root directory, which is still used to determine whether a file belongs to the code base.

Related issues

Part of the fix for #87.

Proposed changes

  • Remove --root-dir option from arguments.
  • Remove root directory deprecation warning.
  • Set root directory to the current working directory unconditionally.

Previously deprecated in 1.2.0.

This commit does not remove the concept of a root directory, which
is still used to determine whether a file belongs to the code base.

Signed-off-by: John Pennycook <john.pennycook@intel.com>
@Pennycook Pennycook added the enhancement New feature or request label Mar 28, 2024
@Pennycook Pennycook added this to the 2.0.0 milestone Mar 28, 2024
@Pennycook Pennycook merged commit 1482c03 into intel:main Apr 3, 2024
2 checks passed
@Pennycook Pennycook deleted the remove-rootdir-option branch April 3, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants