Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml migration #94

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

laserkelvin
Copy link
Contributor

Related issues

Related to #93, which required either a requirements.txt or pyproject.toml specification for setup_python action.

Proposed changes

  • Moves bulk of setup configuration from setup.py to pyproject.toml

Signed-off-by: Kin Long Kelvin Lee <kin.long.kelvin.lee@intel.com>
Signed-off-by: Kin Long Kelvin Lee <kin.long.kelvin.lee@intel.com>
@laserkelvin laserkelvin added the enhancement New feature or request label Apr 3, 2024
Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing.

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: Kin Long Kelvin Lee <kin.long.kelvin.lee@intel.com>
@laserkelvin laserkelvin merged commit 9a474a5 into intel:main Apr 3, 2024
2 checks passed
@laserkelvin laserkelvin deleted the pyproject-migration branch April 3, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants