Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new json format for output #3980

Merged
merged 6 commits into from
Aug 8, 2024
Merged

feat: new json format for output #3980

merged 6 commits into from
Aug 8, 2024

Conversation

mastersans
Copy link
Contributor

@mastersans mastersans commented Mar 25, 2024

fixes: #3259

  • Initial implementation of Json2 format.
  • Test and Documentation.
  • schema updation in $schema field.

Temporary file is added for reference.

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 30.66667% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 81.04%. Comparing base (d6cbe40) to head (87b70ff).
Report is 225 commits behind head on main.

Files Patch % Lines
cve_bin_tool/output_engine/json_output.py 24.59% 46 Missing ⚠️
cve_bin_tool/output_engine/__init__.py 33.33% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3980      +/-   ##
==========================================
+ Coverage   75.41%   81.04%   +5.62%     
==========================================
  Files         808      821      +13     
  Lines       11983    12607     +624     
  Branches     1598     1953     +355     
==========================================
+ Hits         9037    10217    +1180     
+ Misses       2593     1962     -631     
- Partials      353      428      +75     
Flag Coverage Δ
longtests 80.59% <30.66%> (+5.17%) ⬆️
win-longtests 79.07% <30.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mastersans
Copy link
Contributor Author

hey @anthonyharrison i have got this initial implementation for json format, can you check it out.

@mastersans
Copy link
Contributor Author

@terriko can you check it out too, also should i try to finish this one before 3.3 release so that it can go with the release or it should be reserved for 3.3.1 ?

@@ -0,0 +1,214 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for current reference

@terriko terriko added this to the 3.3.1 milestone Apr 10, 2024
@terriko
Copy link
Contributor

terriko commented Apr 10, 2024

I've flagged this as being for 3.3.1 since I'm trying to pare down my todo list before the 3.3 release now.

@mastersans
Copy link
Contributor Author

mastersans commented Apr 17, 2024

hey @anthonyharrison can you take a look at this one for review?

@mastersans mastersans marked this pull request as draft May 2, 2024 01:05
@mastersans mastersans marked this pull request as ready for review June 26, 2024 15:35
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a merge conflict resolution. I think we're also still waiting on a review from @anthonyharrison ? Let's aim to get this merged by next week because I'd very much like it to be in the pre-release for 3.4.

Signed-off-by: sanskarsharma3110@gmail.com <sanskarsharma3110@gmail.com>
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I don't know if @anthonyharrison is going to get a chance, but I've read through it again and it looks good to me, so let's get this merged and if we need to make tweaks they can come in separate PRs. I think we probably still want to have an actual schema so we can set up validation tests with it, but I'll open a separate issue for that and tag you.

Thanks again for being so patient on this @mastersans !

@terriko terriko merged commit 83b22b9 into intel:main Aug 8, 2024
22 checks passed
@mastersans mastersans deleted the json2 branch August 14, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Additional data included in JSON output file
3 participants