-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new json format for output #3980
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3980 +/- ##
==========================================
+ Coverage 75.41% 81.04% +5.62%
==========================================
Files 808 821 +13
Lines 11983 12607 +624
Branches 1598 1953 +355
==========================================
+ Hits 9037 10217 +1180
+ Misses 2593 1962 -631
- Partials 353 428 +75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hey @anthonyharrison i have got this initial implementation for json format, can you check it out. |
@terriko can you check it out too, also should i try to finish this one before 3.3 release so that it can go with the release or it should be reserved for 3.3.1 ? |
@@ -0,0 +1,214 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for current reference
I've flagged this as being for 3.3.1 since I'm trying to pare down my todo list before the 3.3 release now. |
hey @anthonyharrison can you take a look at this one for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this needs a merge conflict resolution. I think we're also still waiting on a review from @anthonyharrison ? Let's aim to get this merged by next week because I'd very much like it to be in the pre-release for 3.4.
Signed-off-by: sanskarsharma3110@gmail.com <sanskarsharma3110@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I don't know if @anthonyharrison is going to get a chance, but I've read through it again and it looks good to me, so let's get this merged and if we need to make tweaks they can come in separate PRs. I think we probably still want to have an actual schema so we can set up validation tests with it, but I'll open a separate issue for that and tag you.
Thanks again for being so patient on this @mastersans !
fixes: #3259
Temporary file is added for reference.