Add platforms to avoid dst/src overlap

Send dst src operand overlap may cause dead lock due to SBID dependence
intel · Aug 29, 2024 · c0b875d · c0b875d
1 parent 041f93a
commit c0b875d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/IGC/Compiler/CISACodeGen/CISABuilder.cpp b/IGC/Compiler/CISACodeGen/CISABuilder.cpp
@@ -5251,11 +5251,6 @@ namespace IGC
  SaveOption(vISA_noSendSrcDstOverlap, true);
  }
 
- if (m_program->m_Platform->WaDisableSendSrcDstOverlap())
- {
- SaveOption(vISA_noSendSrcDstOverlap, true);
- }
-
  // Set to stitch all functions to all kernels in a VISABuidler
  SaveOption(vISA_noStitchExternFunc, false);
 

diff --git a/IGC/Compiler/CISACodeGen/Platform.hpp b/IGC/Compiler/CISACodeGen/Platform.hpp
@@ -1567,10 +1567,12 @@ bool WaGeoShaderURBAllocReduction() const
 
 bool WaDisableSendSrcDstOverlap() const
 {
- return (!IGC_IS_FLAG_ENABLED(DisableSendSrcDstOverlapWA)) &&
- (m_SkuTable.FtrWddm2Svm != 0 || m_platformInfo.eRenderCoreFamily == IGFX_GEN10_CORE ||
- m_platformInfo.eRenderCoreFamily == IGFX_GEN11_CORE);
-
+ return (!IGC_IS_FLAG_ENABLED(DisableSendSrcDstOverlapWA)) &&
+ (m_SkuTable.FtrWddm2Svm != 0 ||
+ m_platformInfo.eRenderCoreFamily == IGFX_GEN10_CORE ||
+ m_platformInfo.eRenderCoreFamily == IGFX_GEN11_CORE ||
+ (m_platformInfo.eProductFamily >= IGFX_PVC &&
+ m_platformInfo.eProductFamily <= IGFX_ARROWLAKE));
 }
 
 bool WaInsertHDCFenceBeforeEOTWhenSparseAliasedResources() const

diff --git a/visa/HWCaps.inc b/visa/HWCaps.inc
@@ -334,8 +334,8 @@ bool has8ByteA64Gather() const { return getPlatform() != GENX_TGLLP; }
 bool WaDisableSendSrcDstOverlap() const {
  return getOption(vISA_noSendSrcDstOverlap) ||
  (m_options->getTarget() == VISA_CM && getPlatform() >= GENX_SKL &&
- getPlatform() < GENX_TGLLP) ||
- getPlatform() == GENX_ICLLP;
+ getPlatform() < GENX_TGLLP) || getPlatform() == GENX_ICLLP ||
+  (getPlatform() >= Xe_MTL && getPlatform() <= Xe_PVCXT);
 }
 
 bool isXeLP() const { return getPlatform() == GENX_TGLLP; }