VISA_BUILDER_API update: Remove the deprecated parameter from VISABu…

…ilder::Compile(). Remove the output std::ostream pointer which is deprecated and no longer used from the API.
intel · Aug 1, 2023 · e283575 · e283575
1 parent ef1d1e4
commit e283575
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 9 deletions.
diff --git a/IGC/Compiler/CISACodeGen/CISABuilder.cpp b/IGC/Compiler/CISACodeGen/CISABuilder.cpp
@@ -6127,7 +6127,7 @@ namespace IGC
         }
         VISAKernel *pMainKernel = vAsmTextBuilder->GetVISAKernel(kernelName);
         m_vIsaCompileStatus = vAsmTextBuilder->Compile(
-            m_enableVISAdump ? GetDumpFileName("isa").c_str() : "", nullptr,
+            m_enableVISAdump ? GetDumpFileName("isa").c_str() : "",
             emitVisaOnly);
 
         return pMainKernel;
@@ -6195,7 +6195,8 @@ namespace IGC
 
             jitInfo->stats.scratchSpaceSizeLimit = m_program->ProgramOutput()->m_scratchSpaceSizeLimit;
             m_vIsaCompileStatus = vbuilder->Compile(
-                m_enableVISAdump ? GetDumpFileName("isa").c_str() : "", nullptr, emitVisaOnly);
+                m_enableVISAdump ? GetDumpFileName("isa").c_str() : "",
+                emitVisaOnly);
         }
 
         COMPILER_TIME_END(m_program->GetContext(), TIME_CG_vISACompile);

diff --git a/IGC/VectorCompiler/lib/GenXCodeGen/GenXCisaBuilder.cpp b/IGC/VectorCompiler/lib/GenXCodeGen/GenXCisaBuilder.cpp
@@ -6278,7 +6278,7 @@ class GenXFinalizer : public ModulePass {
         BC->isaDumpsEnabled() && BC->hasShaderDumper()
             ? BC->getShaderDumper().composeDumpPath("final.isa").c_str()
             : "",
-        nullptr, BC->emitVisaOnly()));
+        BC->emitVisaOnly()));
 
     if (!BC->isDisableFinalizerMsg())
       dbgs() << CisaBuilder->GetCriticalMsg();

diff --git a/visa/BuildCISAIR.h b/visa/BuildCISAIR.h
@@ -75,7 +75,6 @@ class CISA_IR_Builder : public VISABuilder {
   VISA_BUILDER_API int AddPayloadSection(VISAFunction *&function,
                                          const char *functionName) override;
   VISA_BUILDER_API int Compile(const char *isaFileNameint,
-                               std::ostream *os = nullptr,
                                bool emit_visa_only = false) override;
 
   VISA_BUILDER_API void SetOption(vISAOptions option, bool val) override {

diff --git a/visa/BuildCISAIRImpl.cpp b/visa/BuildCISAIRImpl.cpp
@@ -1550,10 +1550,7 @@ int CISA_IR_Builder::ParseVISAText(const std::string &visaFile) {
 // compilation. Currently it is a .isa file.
 // TODO: Remove the ostream parameter used to emit visa binary.
 // default size of the kernel mem manager in bytes
-int CISA_IR_Builder::Compile(const char *nameInput, std::ostream *os,
-                             bool emit_visa_only) {
-  vISA_ASSERT(!os, "std::ostream * parameter is deprecated and expected to be "
-                   "null.");
+int CISA_IR_Builder::Compile(const char *nameInput, bool emit_visa_only) {
   stopTimer(
       TimerID::BUILDER); // TIMER_BUILDER is started when builder is created
   int status = VISA_SUCCESS;

diff --git a/visa/include/VISABuilderAPIDefinition.h b/visa/include/VISABuilderAPIDefinition.h
@@ -1240,7 +1240,6 @@ class VISABuilder {
   VISA_BUILDER_API virtual int AddPayloadSection(VISAFunction *&function,
                                                  const char *functionName) = 0;
   VISA_BUILDER_API virtual int Compile(const char *isaFileNameint,
-                                       std::ostream *os = nullptr,
                                        bool emit_visa_only = false) = 0;
 
   VISA_BUILDER_API virtual void SetOption(vISAOptions option, bool val) = 0;