Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest.skip() (added from our team)in UT, check FAILED cases. #1434

Closed
AshburnLee opened this issue Jun 21, 2024 · 5 comments · Fixed by #1517
Closed

Remove pytest.skip() (added from our team)in UT, check FAILED cases. #1434

AshburnLee opened this issue Jun 21, 2024 · 5 comments · Fixed by #1517

Comments

@AshburnLee
Copy link
Contributor

AshburnLee commented Jun 21, 2024

  1. Find all the "pytest.skip()" added by our team. Comment out them.
  2. Run all the tests, some of them may pass, some of them may fail.
  3. Check failed cases and see if they have already being tracked in the existing issues, if no, file a new issue to track.
  4. Remove "pytest.skip()" added by our team.
  5. Do the above on both Rolling & LTS.
@AshburnLee
Copy link
Contributor Author

AshburnLee commented Jun 28, 2024

Status update on Rolling:

There are 19 pytest.skip that were added by our team, they are in a single test file: test_core.py. There are 166 FAILED cases, 6 of them have diff issue:

  • test_core.py::test_inline_asm[1] Arrays are not equal
  • test_core.py::test_inline_asm_multiple_outputs Arrays are not equal
  • test_core.py::test_inline_asm_packed[1] Arrays are not equal
  • test_core.py::test_inline_asm_packed_multiple_outputs Arrays are not equal
  • test_core.py::test_inline_asm_with_pointers[1] Arrays are not equal

The above 5 cases are supposed to be skipped, checkout issue#223

  • test_core.py::test_precise_math[1-tl.math.sqrt_rn(x)-tl.math.sqrt(x.to(tl.float64)).to(tl.float32)] Full diff issues#847 is tracking
  • The rest 160 cases are test_dot3d, all core dumped. issue#500 is tracking

Todo: I will put those cases in a skiplist and remove pytest.skip from code

@AshburnLee
Copy link
Contributor Author

AshburnLee commented Jul 1, 2024

Update:

  • Compared with OpenAI Triton and found 8 pytest.skip in test_core.py that were added by us. Removed and put FAILED in deselect files.

  • Below FAILED is being tracked:

test_precise_math[1-tl.math.sqrt_rn(x)-tl.math.sqrt(x.to(tl.float64)).to(tl.float32)] has been tracked by #847
test_dot3d[*] has been tracked by #500

test_reduce[4-32-1-xor_sum-bool-shape173-1-False]
test_reduce[4-32-1-xor_sum-bool-shape175-1-False]
test_reduce[4-32-1-xor_sum-bool-shape177-1-False]
test_reduce[64-16-1-xor_sum-bool-shape173-1-False]
test_reduce[64-16-1-xor_sum-bool-shape175-1-False]
test_reduce[64-16-1-xor_sum-bool-shape177-1-False] has been tracked by #1535

test_store_constant_default_dtype[1] has been tracked by #1534
test_dot_without_load[float16] has been tracked by #671
test_masked_load_shared_memory[dtype1] has been tracked by #671

  • Create an issue for the following FAILED:

test_tl_range has been tracked by #1541

test_dot_max_num_imprecise_acc[*] has been tracked by #1541

@AshburnLee
Copy link
Contributor Author

Update:

test_reduce[4-32-1-xor_sum-bool-shape173-1-False]
test_reduce[4-32-1-xor_sum-bool-shape175-1-False]
test_reduce[4-32-1-xor_sum-bool-shape177-1-False]
test_reduce[64-16-1-xor_sum-bool-shape173-1-False]
test_reduce[64-16-1-xor_sum-bool-shape175-1-False]
test_reduce[64-16-1-xor_sum-bool-shape177-1-False] has been tracked by #1535

Those 6 cases now passed. That issue has been closed 2 days ago

@AshburnLee
Copy link
Contributor Author

Update:

@AshburnLee
Copy link
Contributor Author

As discussed, skiplist for conda basekit build and test will not be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants