Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less verbose auto-update-translator-cid #2551

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

pbchekin
Copy link
Contributor

@pbchekin pbchekin commented Oct 24, 2024

Fixes #2302.

@pbchekin
Copy link
Contributor Author

Example: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/11491960986/job/31985235759
image

Copy link
Contributor

@kwasd kwasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@leshikus leshikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if testing all commit ids is really needed; we only need to find the last one which is good enough

@pbchekin
Copy link
Contributor Author

I wonder if testing all commit ids is really needed; we only need to find the last one which is good enough

Sometimes the latest commit from main does not work for us for different reasons, for example a newer llvm is required, so we need to descend from latest commit to the pinned one to find the good one. Ideally it should be a binary search, but it is out of the scope of this PR.

@pbchekin pbchekin merged commit a5140b7 into main Oct 24, 2024
5 checks passed
@pbchekin pbchekin deleted the 2302-less-verbose-workflow branch October 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs for "Automate update Translator cid" are not readable
3 participants