Revert "Revert "Add back barrier after asserts (#5043)"" #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 555d666.
anmyachev
force-pushed
the
amyachev/issue2644
branch
from
cef03bf
to
9ae7340
Compare
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
force-pushed
the
amyachev/issue2644
branch
from
9ae7340
to
4ccb41f
Compare
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
force-pushed
the
amyachev/issue2644
branch
from
ffeeb35
to
52f454c
Compare
anmyachev
requested review from
whitneywhtsang,
etiotto,
alexbaden and
victor-eds
and removed request for
whitneywhtsang
victor-eds
approved these changes
Nov 11, 2024
|
@victor-eds thanks for review! |
alexbaden
pushed a commit
that referenced
this pull request
Nov 13, 2024
Closes #2644 The error (more details: #2644 (comment)) seems to be that the operation is incorrectly inserted into the block. My best guess is that we need to explicitly insert a barrier at the beginning of the `thenBlock`. However I don't know the exact reason why this code works for nvidia (maybe because of the different number of instructions that initially replace `"gpu.barrier"() : () -> ()` however I'm not sure). ```bash python: /home/runner/work/triton/triton/llvm-project/llvm/include/llvm/ADT/ilist_iterator.h:168: llvm::ilist_iterator::reference llvm::ilist_iterator<llvm::ilist_detail::node_options<mlir::Operation, true, false, void, false, void>, false, false>::operator*() const [OptionsT = llvm::ilist_detail::node_options<mlir::Operation, true, false, void, false, void>, IsReverse = false, IsConst = false]: Assertion `!NodePtr->isKnownSentinel()' failed. Aborted (core dumped) ``` --------- Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com> (cherry picked from commit 26781e4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2644
The error (more details: #2644 (comment)) seems to be that the operation is incorrectly inserted into the block. My best guess is that we need to explicitly insert a barrier at the beginning of the
thenBlock. However I don't know the exact reason why this code works for nvidia (maybe because of the different number of instructions that initially replace"gpu.barrier"() : () -> ()however I'm not sure).