[XPU][OptEW] Allow multiple warps in non-sliced dimension #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
requested review from
whitneywhtsang,
etiotto,
chengjunlu and
a team
|
Second step for #2562. Need to evaluate whether this is enough work on the pass or we need to extend it. |
Allow multiple warps in non-sliced dimension as long as there are `n*sub_group_size` contiguous elements per warp in the non-sliced dimension. Signed-off-by: victor-eds <victor.perez@codeplay.com>
victor-eds
force-pushed
the
optimize-elementwise-multi-warp
branch
from
1157096
to
a971b85
Compare
etiotto
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple warps in non-sliced dimension as long as there are
n*sub_group_sizecontiguous elements per warp in the non-sliced dimension.