Skip to content

Commit

Permalink
[SYCL] quick fix for no_duplicate_devices (#15337)
Browse files Browse the repository at this point in the history
quick fix for no_duplicate_devices that also works around the extra
logging being performed by URLZ


The problem is that URLZA added unguarded debug statements. So every run
of any sycl app outputs ```ZE_LOADER_DEBUG_TRACE:Using Loader Library
Path:
ZE_LOADER_DEBUG_TRACE:Tracing Layer Library Path:
libze_tracing_layer.so.1``` when running on stderr, even without setting
DEBUG_TRACE.

This test failed because it uses `&>` to pipe both stderr and stdout to
the FileCheck, which then chokes on the unexpected output. This PR fixes
this test by using just `>`.

The change to URLZA to NOT constantly output is under review, IIRC.
  • Loading branch information
cperkinsintel authored Sep 13, 2024
1 parent c2af484 commit 18081b9
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions sycl/test-e2e/OneapiDeviceSelector/no_duplicate_devices.cpp
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
// REQUIRES: opencl, cpu
// RUN: %{build} -o %t.out
// RUN: env ONEAPI_DEVICE_SELECTOR="opencl:*" %{run-unfiltered-devices} %t.out 1 &> tmp.txt
// RUN: env ONEAPI_DEVICE_SELECTOR="opencl:*" %{run-unfiltered-devices} %t.out 1 > tmp.txt
// RUN: cat tmp.txt | env ONEAPI_DEVICE_SELECTOR="opencl:*,cpu" %{run-unfiltered-devices} %t.out
// RUN: cat tmp.txt | env ONEAPI_DEVICE_SELECTOR="opencl:cpu,cpu" %{run-unfiltered-devices} %t.out

// https://github.com/intel/llvm/issues/15288
// XFAIL: linux && gpu-intel-gen12

// on the first run we pass a dummy arg to the app. On seeing that, we count the
// number of CPU devices and output it. That is piped to a file. On subsequent
// runs we cat the file and pipe that to app. The app then compares the number
Expand Down

0 comments on commit 18081b9

Please sign in to comment.