Skip to content

Commit

Permalink
[SYCL][ClangLinkerWrapper] Unconditionally pass -properties to sycl-p…
Browse files Browse the repository at this point in the history
…ost-link (#14541)

In the old offloading model we have an indirect target dependency
because -properties is mutually exclusive with -ir-output-only, and the
later option does depend on the triple.

However in the new offloading model we currently don’t ever pass
-ir-output-only, so we should always be able to pass -properties, at
least for now.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
  • Loading branch information
sarnex authored Jul 12, 2024
1 parent 64a1320 commit 1c13e6f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -545,8 +545,9 @@ getTripleBasedSYCLPostLinkOpts(const ArgList &Args,
else
PostLinkArgs.push_back("-spec-const=emulation");

if (Triple.isSPIROrSPIRV() || SYCLNativeCPU)
PostLinkArgs.push_back("-properties");
// TODO: If we ever pass -ir-output-only based on the triple,
// make sure we don't pass -properties.
PostLinkArgs.push_back("-properties");

// See if device code splitting is already requested. If not requested, then
// set -split=auto for non-FPGA targets.
Expand Down

0 comments on commit 1c13e6f

Please sign in to comment.