Skip to content

Commit

Permalink
[SYCL][CUDA][HIP] Remove CUDA and HIP PI unit tests (#12459)
Browse files Browse the repository at this point in the history
These tests are not currently running and are covered in other test
suites:

* `test_primary_context.cpp`
  * Deprecated feature, covered in `test-e2e/Basic/context.cpp`
* `test_commands.cpp`
  * Covered by UR CTS
* `test_sampler_properties.cpp`
* Covered by UR CTS:
https://github.com/oneapi-src/unified-runtime/tree/main/test/conformance/sampler
* `PlatformTest.cpp`
* Covered by UR CTS:
https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/platform/urPlatformGetInfo.cpp
* `test_device.cpp`
* Covered by UR CTS:
https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/device/urDeviceGetInfo.cpp
* `EnqueueMemTest.cpp`
* Covered by UR CTS:
https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/enqueue/urEnqueueMemBufferFill.cpp
* `test_mem_obj.cpp`
  * Moved to UR CTS
* `test_contexts.cpp`
*
https://github.com/oneapi-src/unified-runtime/blob/main/test/adapters/cuda/context_tests.cpp
* `test_kernels.cpp`
*
https://github.com/oneapi-src/unified-runtime/blob/main/test/adapters/cuda/kernel_tests.cpp
* `test_base_objects.cpp`
  * Basic tests mostly covered in UR
* `test_interop_get_native.cpp`
  * Mostly covered in UR tests and E2E tests

After this both the CUDA and HIP directories could be removed. There are
two PI tests remaining, one with regards to xpti handling of PI call
arguments, and one regarding OpenCL interop ownership.
  • Loading branch information
npmiller committed Feb 5, 2024
1 parent 015deb1 commit b781e6c
Show file tree
Hide file tree
Showing 25 changed files with 0 additions and 3,352 deletions.
10 changes: 0 additions & 10 deletions sycl/unittests/pi/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
set(CMAKE_CXX_EXTENSIONS OFF)

add_sycl_unittest(PiTests OBJECT
EnqueueMemTest.cpp
PiMock.cpp
PlatformTest.cpp
PiUtility.cpp
pi_arguments_handler.cpp
piInteropRetain.cpp
Expand All @@ -13,11 +11,3 @@ add_dependencies(PiTests sycl)
target_include_directories(PiTests PRIVATE SYSTEM ${sycl_inc_dir})
target_include_directories(PiTests PRIVATE ${sycl_src_dir}/../tools/xpti_helpers)

if("cuda" IN_LIST SYCL_ENABLE_PLUGINS)
add_subdirectory(cuda)
endif()

if("hip" IN_LIST SYCL_ENABLE_PLUGINS)
add_subdirectory(hip)
endif()

152 changes: 0 additions & 152 deletions sycl/unittests/pi/EnqueueMemTest.cpp

This file was deleted.

113 changes: 0 additions & 113 deletions sycl/unittests/pi/PlatformTest.cpp

This file was deleted.

32 changes: 0 additions & 32 deletions sycl/unittests/pi/cuda/CMakeLists.txt

This file was deleted.

20 changes: 0 additions & 20 deletions sycl/unittests/pi/cuda/CudaUtils.hpp

This file was deleted.

Loading

0 comments on commit b781e6c

Please sign in to comment.