Skip to content

Commit

Permalink
Address Greg's comments: Store API matching and fix argument name
Browse files Browse the repository at this point in the history
  • Loading branch information
dkhaldi committed Feb 20, 2024
1 parent 66223c4 commit d96ebee
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -148,21 +148,27 @@ template <typename Group, typename T, size_t Rows, size_t Cols,
access::decorated IsDecorated>
void joint_matrix_store(Group g,
const joint_matrix<Group, T, use::a, Rows, Cols, Layout> &res,
multi_ptr<T, Space, IsDecorated> src, size_t stride);
multi_ptr<T, Space, IsDecorated> dest, size_t stride);

template <typename Group, typename T, size_t Rows, size_t Cols,
layout Layout, access::address_space Space,
access::decorated IsDecorated>
void joint_matrix_store(Group g,
const joint_matrix<Group, T, use::b, Rows, Cols, Layout> &res,
multi_ptr<T, Space, IsDecorated> src, size_t stride);
multi_ptr<T, Space, IsDecorated> dest, size_t stride);

// Only available when Layout != layout::dynamic
template <typename Group, typename T, size_t Rows, size_t Cols,
use Use, layout Layout, typename PropertyListT>
layout Layout, typename PropertyListT>
void joint_matrix_store(Group g,
joint_matrix<Group, T, Use, Rows, Cols, Layout> &res,
ext::oneapi::experimental::annotated_ptr<T, PropertyListT> src,
const joint_matrix<Group, T, use::a, Rows, Cols, Layout> &res,
ext::oneapi::experimental::annotated_ptr<T, PropertyListT> dest,
size_t stride);

template <typename Group, typename T, size_t Rows, size_t Cols,
layout Layout, typename PropertyListT>
void joint_matrix_store(Group g,
const joint_matrix<Group, T, use::b, Rows, Cols, Layout> &res,
ext::oneapi::experimental::annotated_ptr<T, PropertyListT> dest,
size_t stride);

} // namespace sycl::ext::intel::experimental::matrix
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ written in a row (`row_major`), column major (`col_major`)
fashion. `stride` describes the number of elements between consecutive
rows for the row major layout, or between columns for the column major layout.

The overload of `joint_matrix_store` takes
The second overload of `joint_matrix_store` takes
`sycl::ext::oneapi::experimental::annotated_ptr` as argument instead
of `sycl::multi_ptr`. The property list associated with the
`annotated_ptr` argument represents the compile-time constant
Expand Down Expand Up @@ -433,7 +433,7 @@ joint_matrix_apply(sg, C, [=](T &x) {
namespace sycl::ext::oneapi::experimental::matrix {

template <size_t Rows, size_t Cols, typename Group, typename T,
typename Properties = ext::oneapi::experimental::empty_properties_t>
typename Properties = empty_properties_t>
void joint_matrix_prefetch(Group g, T* ptr, size_t stride, layout Layout,
Properties properties = {});

Expand Down

0 comments on commit d96ebee

Please sign in to comment.