Skip to content

Commit

Permalink
BasicAA: Fix assert when indexing address spaces with different sizes…
Browse files Browse the repository at this point in the history
… (#103713) (#15347)

Cherry pick llvm/llvm-project#103713 to fix AMD
postcommit testing.

Closes: #15227

Co-authored-by: Matt Arsenault <Matthew.Arsenault@amd.com>
  • Loading branch information
sarnex and arsenm authored Sep 11, 2024
1 parent 81aacfa commit da2ff3c
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
3 changes: 3 additions & 0 deletions llvm/lib/Analysis/BasicAliasAnalysis.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,9 @@ struct CastedValue {
}

bool hasSameCastsAs(const CastedValue &Other) const {
if (V->getType() != Other.V->getType())
return false;

if (ZExtBits == Other.ZExtBits && SExtBits == Other.SExtBits &&
TruncBits == Other.TruncBits)
return true;
Expand Down
18 changes: 18 additions & 0 deletions llvm/test/Analysis/BasicAA/issue103500.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
; RUN: opt -aa-pipeline=basic-aa -passes=aa-eval -print-all-alias-modref-info -disable-output %s 2>&1 | FileCheck %s

target datalayout = "p0:64:64-p5:32:32"

; CHECK: Function: indexing_different_sized_addrspace: 2 pointers, 0 call sites
; CHECK: MayAlias: i32* %gep.in.0, i32 addrspace(5)* %gep.in.5.1

define i1 @indexing_different_sized_addrspace(ptr addrspace(5) %arg, i64 %arg1, i32 %arg2) {
bb:
%arg.addrspacecast = addrspacecast ptr addrspace(5) %arg to ptr
%gep.in.5 = getelementptr i8, ptr addrspace(5) %arg, i32 16
%gep.in.0 = getelementptr i8, ptr %arg.addrspacecast, i64 %arg1
%gep.in.5.1 = getelementptr i8, ptr addrspace(5) %gep.in.5, i32 %arg2
%load.0 = load i32, ptr %gep.in.0, align 4
%load.1 = load i32, ptr addrspace(5) %gep.in.5.1, align 4
%cmp = icmp slt i32 %load.0, %load.1
ret i1 %cmp
}

0 comments on commit da2ff3c

Please sign in to comment.