Skip to content

Commit

Permalink
[SYCL][NATIVECPU] Empty implementations for cooperative functions (#1…
Browse files Browse the repository at this point in the history
…2809)

Adds empty implementations for `piextEnqueueCooperativeKernelLaunch` and
`piextKernelSuggestMaxCooperativeGroupCount`. Currently we just return
`PI_ERROR_INVALID_OPERATION`, the actual call to the corresponding UR
function will be added in a follow up PR.
  • Loading branch information
PietroGhg authored Feb 27, 2024
1 parent 55d903b commit f7c26d9
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
14 changes: 14 additions & 0 deletions sycl/plugins/native_cpu/pi_native_cpu.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1252,6 +1252,20 @@ pi_result piextCommandBufferAdviseUSM(
SyncPointWaitList, SyncPoint);
}

pi_result piextEnqueueCooperativeKernelLaunch(
pi_queue , pi_kernel , pi_uint32 ,
const size_t *, const size_t *,
const size_t *, pi_uint32 ,
const pi_event *, pi_event *) {
return PI_ERROR_INVALID_OPERATION;
}

pi_result piextKernelSuggestMaxCooperativeGroupCount(
pi_kernel , size_t , size_t ,
pi_uint32 *) {
return PI_ERROR_INVALID_OPERATION;
}

// Initialize function table with stubs.
#define _PI_API(api) \
(PluginInit->PiFunctionTable).api = (decltype(&::api))(&api);
Expand Down
2 changes: 2 additions & 0 deletions sycl/test/abi/pi_nativecpu_symbol_check.dump
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ piextDeviceSelectBinary
piextDisablePeerAccess
piextEnablePeerAccess
piextEnqueueCommandBuffer
piextEnqueueCooperativeKernelLaunch
piextEnqueueReadHostPipe
piextEnqueueWriteHostPipe
piextEventCreateWithNativeHandle
Expand All @@ -120,6 +121,7 @@ piextKernelGetNativeHandle
piextKernelSetArgMemObj
piextKernelSetArgPointer
piextKernelSetArgSampler
piextKernelSuggestMaxCooperativeGroupCount
piextMemCreateWithNativeHandle
piextMemGetNativeHandle
piextMemImageAllocate
Expand Down

0 comments on commit f7c26d9

Please sign in to comment.