Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][OpenCL] Enable graph extension on OpenCL backend #11718

Merged
merged 6 commits into from
Nov 28, 2023
Merged

[SYCL][OpenCL] Enable graph extension on OpenCL backend #11718

merged 6 commits into from
Nov 28, 2023

Conversation

martygrant
Copy link
Contributor

@martygrant martygrant commented Oct 31, 2023 •
edited by kbenzie
Loading

intel-llvm CI run for adding Command Buffers to the OpenCL Adapter in Unified Runtime - oneapi-src/unified-runtime#966

Also completes follow-on work identified in #11599 to add an OpenCL section to the SYCL-Graphs docs and update the e2e Graph tests. Updating the tests has since been completed in a separate PR - #11877

Depends on #11820 merging first.

@martygrant martygrant requested a review from a team as a code owner October 31, 2023 10:00
EwanC
EwanC reviewed Oct 31, 2023
View reviewed changes
sycl/test-e2e/Graph/Explicit/assume_buffer_outlives_graph_property.cpp Outdated Show resolved Hide resolved
sycl/test-e2e/Graph/graph_exception_global_device_extension.cpp Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Show resolved Hide resolved
sycl/test-e2e/Graph/Explicit/usm_fill.cpp Outdated Show resolved Hide resolved
@EwanC EwanC mentioned this pull request Nov 1, 2023
Closed
@martygrant
Copy link
Contributor Author

In a rebased force-push I have corrected the int Pattern = 3.14f lines in the usm_fill tests, as well as enabling a few more tests for OpenCL as a bug in the urCommandBufferAppendKernelLaunchExp was corrected and will be updated in the PR for it in the UR repo.

@martygrant martygrant force-pushed the martin/updateGraphE2ETests branch 2 times, most recently from f3f47a1 to 7cd2323 Compare November 3, 2023 14:04
@martygrant martygrant requested a review from a team as a code owner November 3, 2023 14:04
@martygrant
Copy link
Contributor Author

Using this PR as the companion to the UR PR oneapi-src/unified-runtime#966 instead of the separate #11719 which I will now close.

@martygrant martygrant marked this pull request as draft November 3, 2023 14:07
@martygrant martygrant mentioned this pull request Nov 3, 2023
Merged
@martygrant martygrant force-pushed the martin/updateGraphE2ETests branch 2 times, most recently from b320377 to 5345bbe Compare November 3, 2023 14:25
@EwanC
Copy link
Contributor

EwanC commented Nov 10, 2023

The Graph E2E tests added by this PR will also need updated as the other tests in this PR have been #11556

@martygrant martygrant mentioned this pull request Nov 14, 2023
Merged
aelovikov-intel pushed a commit that referenced this pull request Nov 17, 2023
@martygrant @EwanC
[SYCL][Graph] Add new 'are_graphs_supported' helper function (#11877)
106bc89 
Add new 'are_graphs_supported' helper function to determine platform
support for Graphs
at runtime rather than the lit '// REQUIRES: <platform>' check at
compile time.

Fixed a bug in the usm_variant tests of trying to instantiate an int
with a float value.

This PR has been create in order to simplify the PR for adding OpenCL
support to the SYCL Graph tests
#11718.

---------

Co-authored-by: Ewan Crawford <ewan@codeplay.com>
martygrant and others added 6 commits November 28, 2023 10:41
@martygrant @reble
[SYCL][OpenCL] Update E2E Graph tests to run using OpenCL, and new he…
7189586 
…lper function to return early if Graphs are not supported by the device. Added OpenCL section to CommandGraph docs.

Co-authored-by: Pablo Reble <pablo@reble.org>
@EwanC @martygrant
Update Documentation with OpenCL limiations
3244eb2 
Describe user facing limitations of OpenCL graphs
backend and document failing tests this directly affects.
@EwanC @martygrant
Throw exception on unsupported entry-point
3756725 
Describe in exception message the name of the
unsupported entry-point.
@martygrant
Update docs wording and removing REQUIRES from devicve_query.cpp
0c84fa5
@kbenzie @martygrant
[UR] Bump tag to 109ed46e
7edd4e3
@martygrant
Update OpenCL wording in SYCL-Graph documentation.
5d38699
@kbenzie
Copy link
Contributor

kbenzie commented Nov 28, 2023

@intel/llvm-gatekeepers please merge.

@sergey-semenov
Copy link
Contributor

@kbenzie This still needs approval from @intel/unified-runtime-reviewers

@kbenzie
Copy link
Contributor

kbenzie commented Nov 28, 2023 •
edited
Loading

@kbenzie This still needs approval from @intel/unified-runtime-reviewers

how foolish of me! approved now.

@sergey-semenov sergey-semenov merged commit 5d75245 into intel:sycl Nov 28, 2023
12 checks passed
steffenlarsen pushed a commit that referenced this pull request Nov 28, 2023
@hdelan @kbenzie
[UR] Run CI for Revert HIP prefetch (#11893)
62690ad 
Run CI for oneapi-src/unified-runtime#936

Depends on #11718 merging first.

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
@EwanC EwanC mentioned this pull request Nov 29, 2023
Closed
@kbenzie kbenzie mentioned this pull request Dec 15, 2023
Closed
17 tasks
callumfare pushed a commit to kbenzie/llvm that referenced this pull request Dec 18, 2023
@martygrant @reble
@EwanC @kbenzie @callumfare
[SYCL][OpenCL] Enable graph extension on OpenCL backend (intel#11718)
795871c 
intel-llvm CI run for adding Command Buffers to the OpenCL Adapter in
Unified Runtime - oneapi-src/unified-runtime#966

Also completes follow-on work identified in intel#11599 to add an OpenCL
section to the SYCL-Graphs docs and update the e2e Graph tests. Updating
the tests has since been completed in a separate PR -
intel#11877

Depends on intel#11820 merging first.

---------

Co-authored-by: Pablo Reble <pablo@reble.org>
Co-authored-by: Ewan Crawford <ewan@codeplay.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
callumfare pushed a commit to kbenzie/llvm that referenced this pull request Dec 18, 2023
@hdelan @kbenzie @callumfare
[UR] Run CI for Revert HIP prefetch (intel#11893)
a24a4a4 
Run CI for oneapi-src/unified-runtime#936

Depends on intel#11718 merging first.

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
This was referenced Jan 8, 2024
Merged
Closed
kbenzie pushed a commit that referenced this pull request Jan 8, 2024
@martygrant @EwanC @kbenzie
[SYCL][Graph] Add new 'are_graphs_supported' helper function (#11877)
4fd28dd 
Add new 'are_graphs_supported' helper function to determine platform
support for Graphs
at runtime rather than the lit '// REQUIRES: <platform>' check at
compile time.

Fixed a bug in the usm_variant tests of trying to instantiate an int
with a float value.

This PR has been create in order to simplify the PR for adding OpenCL
support to the SYCL Graph tests
#11718.

---------

Co-authored-by: Ewan Crawford <ewan@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bensuo Bensuo Bensuo left review comments

@reble reble reble left review comments

@EwanC EwanC EwanC approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@kbenzie kbenzie kbenzie approved these changes

@KseniyaTikhomirova KseniyaTikhomirova Awaiting requested review from KseniyaTikhomirova KseniyaTikhomirova is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
sycl-graph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@martygrant @EwanC @kbenzie @sergey-semenov @reble @Bensuo @aelovikov-intel