[SYCL][DOC] Add an overload for memory_required in joint_sorter #11727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pennycook
requested changes
Jan 24, 2024
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc
Outdated
Show resolved
Hide resolved
Pennycook
approved these changes
Jan 29, 2024
Signed-off-by: Fedorov, Andrey <andrey.fedorov@intel.com>
andreyfe1
force-pushed
the
device_param_for_default_sort
branch
from
5acf0e7
to
3b2b9ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the implementation perspective it's important to have
memory_requiredindefault_sortersdependent on the SYCL device. It happens becausedefault_sortershas no specified algorithm inside it can depend on the specific SYCL device.radix_sortershas specific algorithm (radix sorter) that doesn't depend on the backend.Removed
constexprfor default sorters since it's extra there. It's still fine for radix sorters since the algorithm is fixed and can't depend on the backendSigned-off-by: Fedorov, Andrey andrey.fedorov@intel.com