Use new UR handles for opencl instead of casting mechanism #12172
+356
−420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
3acda17
to
f3f6360
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
3 times, most recently
from
49e2da4
to
69c4f49
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
69c4f49
to
e95d890
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
3 times, most recently
from
bfe155f
to
643dcf3
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
643dcf3
to
503faa9
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
503faa9
to
9eed560
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
9eed560
to
de060f6
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
de060f6
to
4ea421e
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
4ea421e
to
ce846a0
Compare
fabiomestre
reviewed
Feb 16, 2024
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
ad0b462
to
6bd95b1
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
6bd95b1
to
548f37e
Compare
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
548f37e
to
6af465f
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
6af465f
to
8699045
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
2 times, most recently
from
fe28381
to
59549aa
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
approved these changes
Mar 22, 2024
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
59549aa
to
0d14986
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
0d14986
to
22694db
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
Testing-adding-handles-to-opencl
branch
from
22694db
to
ea513e3
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes sycl-rt for opencl interop functionality to use the new UR handles layer for opencl, instead of relying on casting directly handles directly. So, it removes the 1:1 relation between UR/sycl-rt and opencl.
Testing PR for this UR PR