Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph][HIP] Add HIP backend support to SYCL-Graph #12230

Merged
merged 23 commits into from
Mar 1, 2024
Merged

[SYCL][Graph][HIP] Add HIP backend support to SYCL-Graph #12230

merged 23 commits into from
Mar 1, 2024

Conversation

mfrancepillois
Copy link
Contributor

@mfrancepillois mfrancepillois commented Dec 21, 2023 •
edited by kbenzie
Loading

Tests HIP Support for Graph from oneapi-src/unified-runtime#1254 and updates documentation.

Depends on #12753.

@mfrancepillois @al42and
[SYCL][Graph] HIP Support testing
caa7058 
Co-authored-by: Andrey Alekseenko <andrey.alekseenko@scilifelab.se>
@mfrancepillois
[SYCL][Graph] Fix OpenCL backend test fails with CPU device
816cfd3 
Adds missing variable initializations.
Temporary disable `work_group_size_prop.cpp` because the failure results from a bug in the emulation layer.
@mfrancepillois
Disables unsupported test for hip + adds hip as supported in the test…
9ed12b6 
… that checks backend support
@mfrancepillois mfrancepillois changed the title [SYCL][Graph] HIP Support testing [SYCL][Graph] HIP Support Jan 2, 2024
@EwanC EwanC marked this pull request as ready for review February 20, 2024 09:08
@EwanC EwanC requested review from a team as code owners February 20, 2024 09:08
kbenzie
kbenzie reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#12753 needs to merge first since it was merge to UR fisrt.

sycl/plugins/unified_runtime/CMakeLists.txt Outdated Show resolved Hide resolved
@EwanC EwanC changed the title [SYCL][Graph] HIP Support [SYCL][Graph][HIP] Add HIP backend support to SYCL-Graph Feb 27, 2024
@EwanC
Copy link
Contributor

EwanC commented Feb 27, 2024 •
edited
Loading

@intel/llvm-reviewers-runtime Could you review this please, the UR portion of the change has merged

steffenlarsen
steffenlarsen approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. LGTM with a tiny nit.

sycl/test-e2e/Graph/Explicit/enqueue_ordering.cpp Outdated Show resolved Hide resolved
@kbenzie kbenzie mentioned this pull request Feb 29, 2024
Merged
kbenzie
kbenzie reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#12753 has now been merged, please pull in the latest sycl branch chagnes and resolve the conflict on the UR tag.

@mfrancepillois
Copy link
Contributor Author

@intel/llvm-gatekeepers could you please merge this PR?

@steffenlarsen steffenlarsen merged commit 897b270 into intel:sycl Mar 1, 2024
12 checks passed
steffenlarsen pushed a commit that referenced this pull request Mar 7, 2024
@pbalcer @kbenzie
[UR][L0] multi-device event cache optimization (#12863)
acce3b7 
Depends on #12230.

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@EwanC EwanC EwanC approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfrancepillois @EwanC @kbenzie @steffenlarsen