-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Fusion][NoSTL][NFC] Move SYCLModuleInfo to its own header #12413
Conversation
7ff111b
to
1d14253
Compare
✅ With the latest revision this PR passed the C/C++ code formatter. |
1d14253
to
0844c8e
Compare
0844c8e
to
a7d7c80
Compare
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
a7d7c80
to
5e40a85
Compare
@intel/llvm-gatekeepers CUDA failure seems unrelated; could you merge this please? |
Something is going on with CUDA testing. I restarted it, but it failed again. |
https://github.com/intel/llvm/actions/workflows/sycl_linux_precommit_aws.yml looks healthy, I don't think we should merge with the current results. |
Third re-run passed. 🤷 |
@bader Are you ok with merging this? The latest run of the CUDA pipeline passed and I don't see how the non-functional changes in this PR could cause any regression. |
Yes. |
Move
SYCLModuleInfo
class to its own header under thecommon
directory (because it has users fromjit-compiler
andpasses
).This PR is part of a series of changes to remove uses of STL classes in the kernel fusion interface to prevent ABI issues in the future.