Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Fusion][NoSTL][NFC] Move SYCLModuleInfo to its own header #12413

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

jopperm
Copy link
Contributor

@jopperm jopperm commented Jan 17, 2024

Move SYCLModuleInfo class to its own header under the common directory (because it has users from jit-compiler and passes).

This PR is part of a series of changes to remove uses of STL classes in the kernel fusion interface to prevent ABI issues in the future.

@jopperm jopperm self-assigned this Jan 17, 2024
@jopperm jopperm force-pushed the kf-nostl/modinfo branch 2 times, most recently from 7ff111b to 1d14253 Compare January 23, 2024 23:40
@jopperm jopperm marked this pull request as ready for review January 23, 2024 23:40
@jopperm jopperm requested a review from a team as a code owner January 23, 2024 23:40
Copy link
Contributor

github-actions bot commented Jan 23, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
Copy link
Contributor Author

jopperm commented Jan 26, 2024

@intel/llvm-gatekeepers CUDA failure seems unrelated; could you merge this please?

@bader
Copy link
Contributor

bader commented Jan 26, 2024

@intel/llvm-gatekeepers CUDA failure seems unrelated; could you merge this please?

Something is going on with CUDA testing. I restarted it, but it failed again.
@intel/dpcpp-devops-reviewers, do we expect CUDA tests to pass?

@aelovikov-intel
Copy link
Contributor

@intel/llvm-gatekeepers CUDA failure seems unrelated; could you merge this please?

Something is going on with CUDA testing. I restarted it, but it failed again. @intel/dpcpp-devops-reviewers, do we expect CUDA tests to pass?

https://github.com/intel/llvm/actions/workflows/sycl_linux_precommit_aws.yml looks healthy, I don't think we should merge with the current results.

@bader
Copy link
Contributor

bader commented Jan 26, 2024

@intel/llvm-gatekeepers CUDA failure seems unrelated; could you merge this please?

Something is going on with CUDA testing. I restarted it, but it failed again. @intel/dpcpp-devops-reviewers, do we expect CUDA tests to pass?

https://github.com/intel/llvm/actions/workflows/sycl_linux_precommit_aws.yml looks healthy, I don't think we should merge with the current results.

Third re-run passed. 🤷

@sommerlukas
Copy link
Contributor

@bader Are you ok with merging this?

The latest run of the CUDA pipeline passed and I don't see how the non-functional changes in this PR could cause any regression.

@bader
Copy link
Contributor

bader commented Jan 29, 2024

Yes.

@sommerlukas sommerlukas merged commit f4b4a84 into intel:sycl Jan 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants