Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Specify API for explicit update using indices #12486

Merged
merged 27 commits into from
Mar 27, 2024
Merged

[SYCL][Graph] Specify API for explicit update using indices #12486

merged 27 commits into from
Mar 27, 2024

Commits on Jan 24, 2024

  1. [SYCL][Graph] API for explicit update using indices 

    - Adds an API to the spec for updating graph nodes using explicit indices
- Also includes functionality for updating ND-range of kernel nodes
- Note: Current design is only for kernel execution nodes
    @Bensuo
    Bensuo committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d7f5d51 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Update sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc 

    Fix typo

Co-authored-by: Pablo Reble <pablo.reble@intel.com>
    @Bensuo @reble
    Bensuo and reble authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    bfdf750 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Fix update function name, add initial value constructor for dynamic p… 

    …arameter
    @Bensuo
    Bensuo committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ac29d0a View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Addressing review comments 

    - Add update_range node member function for updating using a sycl::range
- Swap parameter order when registering
- Clarify some wording
    @Bensuo
    Bensuo committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5431de4 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Remove dynamic_param ctor, fix example based on changes, minor wordin… 

    …g updates
    @Bensuo
    Bensuo committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    961ae13 View commit details
    Browse the repository at this point in the history

  2. Rework command_graph::update() description

    @Bensuo
    Bensuo committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    ebc2adb View commit details
    Browse the repository at this point in the history

  3. Remove duplicate node synopsis

    @Bensuo
    Bensuo committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    e7fd524 View commit details
    Browse the repository at this point in the history

  4. Improve update_range/nd_range errors, clarify register usage

    @Bensuo
    Bensuo committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    ae5d62d View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Update wording 

    - Update wording of dynamic_parameter::update
- Move error on non-kernel node registration to add() since it is unimplementable in register
    @Bensuo
    Bensuo committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    7b40019 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Fix minor formatting issues

    @Bensuo
    Bensuo committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    0186285 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/sycl' into pablo/explicit-update

    @Bensuo
    Bensuo committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    baefdc2 View commit details
    Browse the repository at this point in the history

  3. Remove extra spaces

    @Bensuo
    Bensuo committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8cb86ee View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Add aspect for querying update support

    @Bensuo
    Bensuo committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    48f9770 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Rename update aspect

    @Bensuo
    Bensuo committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    b63d6c3 View commit details
    Browse the repository at this point in the history

  2. Update aspect description

    @Bensuo
    Bensuo committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e4ec0d4 View commit details
    Browse the repository at this point in the history

  3. updateable -> updatable

    @Bensuo
    Bensuo committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    50db9ad View commit details
    Browse the repository at this point in the history

  4. Fix aspect name

    @Bensuo
    Bensuo committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    605f56f View commit details
    Browse the repository at this point in the history

  5. Add example of accessor usage with dynamic parameters

    @Bensuo
    Bensuo committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    8bcf125 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Merge remote-tracking branch 'origin/sycl' into pablo/explicit-update

    @Bensuo
    Bensuo committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b5db95f View commit details
    Browse the repository at this point in the history

  2. Remove register_with_node

    @Bensuo
    Bensuo committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    8ede6b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Clarify update blocking/wait behaviour 

    - User is not required to wait on previous graph submissions
- update() may perform a blocking wait if required.
    @Bensuo
    Bensuo committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6a6bf5e View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Addressing MR comments 

    - Minor formatting and wording changes
    @Bensuo
    Bensuo committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    40632a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Minor Tweaks 

    - Remove redundant "Note: " annotation.
- Avoid duplicating "Executable Graph Update" section name.
- Reference parameter name in entry-point error description
    @EwanC
    EwanC committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6ec17e3 View commit details
    Browse the repository at this point in the history

  2. Fix typo in section tag

    @EwanC
    EwanC committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    d981ebf View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/sycl' into pablo/explicit-update

    @EwanC
    EwanC committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    c893abd View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Minor editorial touchups

    @EwanC
    EwanC committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6fd83ff View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/sycl' into pablo/explicit-update

    @EwanC
    EwanC committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b23423d View commit details
    Browse the repository at this point in the history