Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][ESIMD] Implement unified memory API for scatter(usm, ...) #12510

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jan 26, 2024

This implements the unified memory API for scatter with USM pointers.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex
Copy link
Contributor Author

sarnex commented Jan 26, 2024

The two Windows CI failures are not related, they are both file deletion problems, the tests passed.

@sarnex sarnex marked this pull request as ready for review January 26, 2024 21:41
@sarnex sarnex requested a review from a team as a code owner January 26, 2024 21:41
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Copy link
Contributor

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished the 1st code-review pass. Please see my comments.

sycl/test-e2e/ESIMD/unified_memory_api/scatter_usm.cpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/intel/experimental/esimd/common.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/intel/esimd/common.hpp Outdated Show resolved Hide resolved
sycl/test/esimd/memory_properties.cpp Show resolved Hide resolved
sycl/include/sycl/ext/intel/esimd/memory.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/intel/esimd/memory.hpp Show resolved Hide resolved
sycl/include/sycl/ext/intel/esimd/memory.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/intel/esimd/memory.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/intel/esimd/memory.hpp Outdated Show resolved Hide resolved
sycl/test/esimd/memory_properties.cpp Show resolved Hide resolved
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@v-klochkov v-klochkov merged commit 0bf2e66 into intel:sycl Jan 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants