Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][NFC] Unify naming scheme for SYCL workflows. #12568

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

bader
Copy link
Contributor

@bader bader commented Jan 31, 2024

All GitHub Actions workflows added by intel/llvm project are expected to use following naming notation:

  1. Name starts with sycl prefix.
  2. Use dash - to separate words (instead of underscore _).

This patches fixes naming of workflows which do not follow this notation.

All GitHub Actions workflows added by intel/llvm project are expected to
use following naming notation:

1. Name starts with `sycl` prefix.
2. Use dash `-` to separate words (instead of underscore `_`).

This patches fixes naming of workflows which do not follow this
notation.
@bader bader requested a review from a team as a code owner January 31, 2024 20:10
@bader
Copy link
Contributor Author

bader commented Jan 31, 2024

This is a fixed version of #12525, which misses name updates inside the workflow and README.md files.

Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope Github won't have different escaping requirements for dash vs. underscores.

@bader
Copy link
Contributor Author

bader commented Jan 31, 2024

Post-commit workflow failure is not related to this change.

Failed Tests (1):
  SYCL :: Config/select_device.cpp

It was detected earlier: #12535 (comment).

@bader bader merged commit 435845b into intel:sycl Jan 31, 2024
25 of 26 checks passed
@bader bader deleted the gha-workflow-naming branch January 31, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants