-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Add logics for aligned_alloc_xxx<T> to deal with unsupported Alignment argument #12569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Alignment argument is not a power of 2 Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
0x12CC
suggested changes
Feb 1, 2024
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
✅ With the latest revision this PR passed the C/C++ code formatter. |
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
….cpp Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
bso-intel
approved these changes
Feb 2, 2024
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logics for aligned_alloc_xxx<T> to return nullptr when the Alignment argument is not a power of 2. Also updated and added a new test file align.cpp used to test such cases (where Alignment is not 2's power). The fixed methods, all in sycl/include/sycl/usm.hpp, are:
aligned_alloc_device<T>
aligned_alloc_shared<T>
aligned_alloc_host<T>
aligned_alloc<T>
*Note that each of these methods has two slighly different versions with different parameter lists.
**Also note that Alignment=0 is considered as a valid "default" case in our implementation so it will not cause nullptr to be returned. (Code here:
llvm/sycl/source/detail/usm/usm_impl.cpp
Line 163 in 435845b
Link to the issue: #11642