Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][libdevice] Add sqrt with rounding mode supported in sycl::ext::intel::math #12571

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Feb 1, 2024

No description provided.

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 1, 2024

Hi, @zettai-reido and @akolesov-intel
This PR adds implementation for sqrt and sqrtf with rounding mode supported in imf libdevice, could you help review it?
Thanks very much.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

Signed-off-by: jinge90 <ge.jin@intel.com>
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sycl-post-link changes LGTM

@againull againull merged commit 6c1dde4 into intel:sycl Feb 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants