Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Make PropertySetRegistry being owning it's content #12582

Merged
merged 4 commits into from
Mar 8, 2024

Commits on Feb 1, 2024

  1. [SYCL] Make PropertySetRegistry owning it's content

    Before this patch PropertySetRegistry used StringRefs
    that point at external data that was supposed to outlive the instance of
    PropertySetRegistry. It wasn't obvious and it might lead to memory bugs.
    This patch makes PropertySetRegistry owning it's content as containers
    usually do.
    
    Also the previous implementation had a property that a content is
    being printed in the order it was added. This patch removes this
    property. However, the patch brings a sorted order in write() method
    in order to make testing as easy as it was. Accordingly, all affected tests
    were aligned to the sorted order.
    
    Also documentation is aligned with doxygen BKSM.
    maksimsab committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    676a364 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Configuration menu
    Copy the full SHA
    69b5124 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Address issues in PR

    Fix failing test in sycl/test/basic_tests.
    Get order of elements preserved as it was initially.
    Align tests correspondingly.
    maksimsab committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    22bc17f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Configuration menu
    Copy the full SHA
    9a12543 View commit details
    Browse the repository at this point in the history