[SYCL][sycl-post-link] Add check for deleted Spec Constant Operands #12597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudarsanam, Arvind <arvind.sudarsanam@intel.com>
|
I will add a test soon. |
asudarsa
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Signed-off-by: Sudarsanam, Arvind <arvind.sudarsanam@intel.com>
asudarsa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
asudarsa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
reviewed
Feb 6, 2024
Comment on lines
+1007
to
+1009
| if (Node->getOperand(0)) { | ||
| auto *Constant = | ||
| cast<ConstantAsMetadata>(Node->getOperand(0))->getValue(); |
There was a problem hiding this comment.
if (auto *O = Node->getOperand(0); O) {
auto *Constant =
cast<ConstantAsMetadata>(O)->getValue();
asudarsa
requested review from
maarquitos14
and removed request for
maarquitos14
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days. |
|
This pull request was closed because it has been stalled for 30 days with no activity. |
|
@asudarsa is this still of interest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we turn on -emit-only-kernel-as-entry-points by default for sycl-post-link tools, there are some entries in some of the specialization constant metadata are not carried over. Hence, a check is required to ensure we are not parsing 'null' specialization constants.
Thanks