Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Fix sycl-ls discovery #12603

Closed
wants to merge 2 commits into from
Closed

Conversation

npmiller
Copy link
Contributor

@npmiller npmiller commented Feb 5, 2024

We should also look for sycl-ls in the PATH and not just in the llvm tools dir.

We should also look for `sycl-ls` in the `PATH` and not just in the llvm
tools dir.
Copy link
Contributor

github-actions bot commented Feb 5, 2024

✅ With the latest revision this PR passed the Python code formatter.

@aelovikov-intel
Copy link
Contributor

Why is that so? Are you trying to use sycl-ls outside of the build?

@aelovikov-intel
Copy link
Contributor

+ @frasercrmck

@npmiller
Copy link
Contributor Author

npmiller commented Feb 5, 2024

Why is that so? Are you trying to use sycl-ls outside of the build?

Specifically, I'm running E2E tests standalone against the release package's clang++, it's located in bin/compiler rather than bin, so the current lit setup isn't able to find sycl-ls.

But more broadly this seems to be the only restrictions to using a compiler and a runtime installed in different locations when running the tests.

@aelovikov-intel
Copy link
Contributor

We have some tight coupling between sycl-ls output format and the E2E infrastructure, so I wouldn't want to pick some random version of it from the PATH...

Can we make it more explicit for the user, maybe by asking to provide the path to sycl-ls explicitly? WDYT?

@npmiller
Copy link
Contributor Author

Closing this.

We've ended up deciding it didn't make that much sense to run tests against the clang++ binary from the release package so we don't need this anymore.

If we do end up revisiting it at some point I do agree that a flag to point to a specific sycl-ls binary would make sense.

@npmiller npmiller closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants