Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph][CUDA] Graph buffer fill node improvement #12605

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

mfrancepillois
Copy link
Contributor

@mfrancepillois mfrancepillois commented Feb 5, 2024

Graph support in the CUDA backend for graph buffer fill nodes has been improved in UR PR oneapi-src/unified-runtime#1319

@EwanC EwanC force-pushed the maxime/cuda-fill-op-improved branch from e2d6cb6 to d8403f4 Compare March 11, 2024 16:28
@EwanC EwanC changed the title [SYCL][Graph] Enable buffer-based e2e tests with the CUDA backend [SYCL][Graph][CUDA] Graph buffer fill node improvement Mar 11, 2024
@EwanC EwanC force-pushed the maxime/cuda-fill-op-improved branch from d8403f4 to 544c02b Compare March 14, 2024 14:12
@EwanC EwanC force-pushed the maxime/cuda-fill-op-improved branch from 544c02b to ecd4a4f Compare March 14, 2024 14:16
@EwanC EwanC marked this pull request as ready for review March 14, 2024 16:41
@EwanC EwanC requested a review from a team as a code owner March 14, 2024 16:41
@kbenzie
Copy link
Contributor

kbenzie commented Mar 14, 2024

@intel/llvm-gatekeepers please merge

@bader bader merged commit d2817d6 into intel:sycl Mar 14, 2024
11 checks passed
@bader
Copy link
Contributor

bader commented Mar 14, 2024

Post-commit failures.
e2e-lin (Intel GEN12 Graphics with Level Zero, ["Linux", "gen12"], --param gpu-intel-gen12=True, ... / Intel GEN12 Graphics with Level Zero

Failed Tests (7):
  SYCL :: Plugin/interop-level-zero-image.cpp
  SYCL :: TaskSequence/concurrent-loops.cpp
  SYCL :: TaskSequence/in-order-async-get.cpp
  SYCL :: TaskSequence/mult-and-add.cpp
  SYCL :: TaskSequence/multi-kernel-task-function-reuse.cpp
  SYCL :: TaskSequence/producer-consumer.cpp
  SYCL :: TaskSequence/struct-array-args-and-return.cpp

e2e-lin (Intel Arc A-Series Graphics with Level Zero, ["Linux", "arc"], --param matrix-xmx8=True ... / Intel Arc A-Series Graphics with Level Zero

Failed Tests (2):
  SYCL :: Plugin/interop-level-zero-image.cpp
  SYCL :: Reduction/reduction_range_3d_rw_reducer_skip.cpp

All these failures are observed on previous commit, so they are caused by this patch.
There is one exception - reduction_range_3d_rw_reducer_skip.cpp. @mfrancepillois, could you confirm that this failure not related to your change, please?

@sommerlukas
Copy link
Contributor

There is one exception - reduction_range_3d_rw_reducer_skip.cpp. @mfrancepillois, could you confirm that this failure not related to your change, please?

That test also failed on unrelated changes here: https://github.com/intel/llvm/actions/runs/8271074040/job/22630465588.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants