[SYCL][Fusion] Avoid deadlock on events with no command group #12621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #12593 |
victor-eds
force-pushed
the
red-deadlock-fix
branch
3 times, most recently
from
c78e136
to
1053ef1
Compare
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
`sycl::queue` shortcut functions, e.g., `sycl::queue::memcpy`, may not create a command group, so events coming from those will not have a command group attached. Avoid deadlock when going through event list in fusion mode. Signed-off-by: Victor Perez <victor.perez@codeplay.com>
victor-eds
force-pushed
the
red-deadlock-fix
branch
from
1053ef1
to
62bd64e
Compare
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Unrelated failing test: |
Should be fixed by #12650. |
sommerlukas
approved these changes
Feb 8, 2024
|
@maarquitos14, @intel/llvm-reviewers-runtime, could you please take a look? This patch is needed to fix post-commit failure |
sergey-semenov
approved these changes
Feb 9, 2024
maarquitos14
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sycl::queueshortcut functions, e.g.,sycl::queue::memcpy, may notcreate a command group, so events coming from those will not have a
command group attached. Avoid deadlock when going through event list
in fusion mode.
Signed-off-by: Victor Perez victor.perez@codeplay.com