[SYCL] Choose image with inlined default values if default value is set explicitly #12626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Make it usable to return default value as well, not only value that was set.
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Feb 8, 2024
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If -fsycl-add-default-spec-consts-image option is used then DPCPP generates a device image where default values of specialization constants are inlined (in addition to regular device image).
Currently we always choose regular device image if somebody calls
set_specialization_constantAPI.This PR improves this behavior: if
set_specialization_constantsets the value equal to default value then we can choose the device image where default values of specialization constants are inlined.