Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Pass gpu-intel-gen12=True when running on Gen12 #12627

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Feb 6, 2024

Let me see if this works, I want to use this param in an E2E test.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@@ -67,6 +67,7 @@ jobs:
target_devices: ext_oneapi_level_zero:gpu;opencl:gpu;opencl:cpu
reset_gpu: true
install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }}
extra_lit_opts: --param gpu-intel-gen12=True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't know how it will affect cpu target. I'm not sure this parameter was designed for multi-target runs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't expect anything weird given the usage of gpu-intel-gen12. Probably in the general case of extra lit options there is a case where passing the same one to cpu and gpu is bad, but this one is pretty restricted so it's probably fine (?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aelovikov-intel Do you know why Linux CI didn't run for this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aelovikov-intel So what's the play, should we try to merge it as is given the CI passed and revert if there's some problem?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't know why post-commit task didn't run here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, most likely an issue with the syntax in the workflow file.

@sarnex sarnex marked this pull request as ready for review February 6, 2024 20:07
@sarnex sarnex requested a review from a team as a code owner February 6, 2024 20:07
@sarnex
Copy link
Contributor Author

sarnex commented Feb 6, 2024

Syntax error hidden deep in some email, marking as draft

@sarnex sarnex marked this pull request as draft February 6, 2024 20:13
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review February 6, 2024 22:05
@sarnex
Copy link
Contributor Author

sarnex commented Feb 6, 2024

Fixed now, ready for review

@sarnex
Copy link
Contributor Author

sarnex commented Feb 6, 2024

SYCL Pre Commit on Windows / e2e / Intel GEN12 Graphics with Level Zero (pull_request) 
This PR: 
  Passed           : 1006 (53.68%)
HEAD~1
  Passed           : 1004 (53.69%)
SYCL Pre Commit on Linux / test (Intel, ["Linux", "gen12"
This PR: 
  Passed           : 1376 (73.43%)
HEAD~1:
  Passed           : 1372 (73.37%)
SYCL Post Commit / e2e-lin (Intel GEN12 Graphics with Level Zero
This PR:
  Passed           : 1269 (67.72%)
HEAD~1:
  Passed           : 1268 (67.66%)
SYCL Post Commit / e2e-lin (Perf tests on Intel GEN12 Graphics system
This PR:
Passed  :    1 (0.05%)
HEAD~1:
 Passed  :    1 (0.05%)
SYCL Post Commit / e2e-win / Intel GEN12 Graphics with Level Zero (pull_request)
This PR: 
Passed           : 1006 (53.68%)
HEAD~1:
 Passed           : 1005 (53.63%)

Seems okay

@sarnex sarnex merged commit 774a662 into intel:sycl Feb 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants