-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Pass gpu-intel-gen12=True when running on Gen12 #12627
Conversation
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@@ -67,6 +67,7 @@ jobs: | |||
target_devices: ext_oneapi_level_zero:gpu;opencl:gpu;opencl:cpu | |||
reset_gpu: true | |||
install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }} | |||
extra_lit_opts: --param gpu-intel-gen12=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't know how it will affect cpu target. I'm not sure this parameter was designed for multi-target runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't expect anything weird given the usage of gpu-intel-gen12
. Probably in the general case of extra lit options there is a case where passing the same one to cpu and gpu is bad, but this one is pretty restricted so it's probably fine (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aelovikov-intel Do you know why Linux CI didn't run for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aelovikov-intel So what's the play, should we try to merge it as is given the CI passed and revert if there's some problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't know why post-commit task didn't run here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, most likely an issue with the syntax in the workflow file.
Syntax error hidden deep in some email, marking as draft |
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Fixed now, ready for review |
Seems okay |
Let me see if this works, I want to use this param in an E2E test.