-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NFC] Refresh inline asm E2E tests #12642
[SYCL][NFC] Refresh inline asm E2E tests #12642
Conversation
This PR should improve tests stability and transparency (when it comes to unsupported tests). List of changes: - switched from `[[intel::reqd_sub_group_size]]` to `[[sycl::reqd_sub_group_size]]` attribute; - removed uses of deprecated `device::has_extension` API: there is no need for that check, because, `[[sycl::reqd_sub_group_size]]` is a core SYCL 2020 functionality; - simplified helpers to remove unnecessary extra arguments which could be inferred otherwise; - updated `REQUIRES` directives to include required sub-group size requirements in there. Adjusted calls to `launchInlineASMTest` helper to consistently pass required sub-group size in there as well;
✅ With the latest revision this PR passed the C/C++ code formatter. |
Really don't like what |
…esh-inline-asm-e2e-tests
Post-commit failures on Arc GPU:
|
|
This PR should improve tests stability and transparency (when it comes to unsupported tests). List of changes:
[[intel::reqd_sub_group_size]]
to[[sycl::reqd_sub_group_size]]
attribute;device::has_extension
API: there is no need for that check, because,[[sycl::reqd_sub_group_size]]
is a core SYCL 2020 functionality;REQUIRES
directives to include required sub-group size requirements in there. Adjusted calls tolaunchInlineASMTest
helper to consistently pass required sub-group size in there as well;