Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][DOC] Extend sycl_ext_oneapi_root_group #12643

Merged
merged 6 commits into from
Feb 7, 2024
Merged

[SYCL][DOC] Extend sycl_ext_oneapi_root_group #12643

merged 6 commits into from
Feb 7, 2024

Conversation

KornevNikita
Copy link
Contributor

Adding new enum "execution_scope" and few member functions

@KornevNikita
[SYCL][DOC] Extend sycl_ext_oneapi_root_group
c869d67 
Adding new enum "execution_scope" and few member functions
@KornevNikita KornevNikita requested a review from a team as a code owner February 7, 2024 11:41
KornevNikita and others added 2 commits February 7, 2024 17:01
@KornevNikita @Pennycook
Apply suggestions from code review
fb810d2 
Co-authored-by: John Pennycook <john.pennycook@intel.com>
@KornevNikita
Add constraints
2855637
Pennycook
Pennycook requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested alternative wording for the constraints. We've been using "narrower" and "broader" in some of the other specifications, and it's less verbose. Sorry for not suggesting this as part of the initial review.

sycl/doc/extensions/proposed/sycl_ext_oneapi_root_group.asciidoc Outdated Show resolved Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_root_group.asciidoc Outdated Show resolved Hide resolved
@KornevNikita @Pennycook
Apply suggestions from code review
3c1dcff 
Co-authored-by: John Pennycook <john.pennycook@intel.com>
KornevNikita added a commit to KornevNikita/llvm that referenced this pull request Feb 7, 2024
@KornevNikita
[SYCL] Align root_group with spec
0bf5145 
Spec: intel#12643
@KornevNikita KornevNikita mentioned this pull request Feb 7, 2024
Closed
@KornevNikita
Copy link
Contributor Author

@Pennycook do you want other folks mentioned in the email to take a look or we're ready to merge?

@Pennycook
Copy link
Contributor

@Pennycook do you want other folks mentioned in the email to take a look or we're ready to merge?

We're ready to merge.

@aelovikov-intel aelovikov-intel merged commit 557df1a into intel:sycl Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pennycook Pennycook Pennycook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KornevNikita @Pennycook @aelovikov-intel