Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Fusion] Test and document group algorithms/function support #12644

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

victor-eds
Copy link
Contributor

Add tests for group_broadcast and permute_group_by_xor when remapping is needed.

Document support for group algorithms and functions in the kernel fusion design document. Kernel fusion supports these constructs, as local range, group id and local id do not change due to remapping.

@victor-eds victor-eds self-assigned this Feb 7, 2024
@victor-eds victor-eds requested a review from a team as a code owner February 7, 2024 11:42
@victor-eds
Copy link
Contributor Author

victor-eds commented Feb 7, 2024

Proof that local ID and group ID are invariant:

This is true after #12538

Add tests for `group_broadcast` and `permute_group_by_xor` when
remapping is needed.

Document support for group algorithms and functions in the kernel
fusion design document. Kernel fusion supports these constructs, as
local range, group id and local id do not change due to remapping.

Signed-off-by: Victor Perez <victor.perez@codeplay.com>
@sommerlukas
Copy link
Contributor

Failure of ESIMD/aot_mixed.cpp is unrelated and should be fixed by #12650.

@sommerlukas sommerlukas merged commit ca4ed6e into intel:sycl Feb 14, 2024
12 of 13 checks passed
@sommerlukas
Copy link
Contributor

Post-commit failures:

SYCL :: Basic/interop/ze_context_device.cpp
SYCL :: Reduction/reduction_range_3d_rw.cpp

Both failures seem unrelated, the reduction test also failed in post-commit for #12693

@victor-eds victor-eds deleted the test-group-algs-remapping branch February 14, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants