Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[ESIMD][E2E] Enable few cases in atomic_update after gpu driver update" #12669

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Revert "[ESIMD][E2E] Enable few cases in atomic_update after gpu driver update" #12669

merged 1 commit into from
Feb 8, 2024

Conversation

ldrumm
Copy link
Contributor

@ldrumm ldrumm commented Feb 8, 2024

Reverts #12639

This regressed atomic_update_acc_dg2_pvc_cmpxchg.cpp

@ldrumm ldrumm requested a review from a team as a code owner February 8, 2024 20:25
@sarnex
Copy link
Contributor

sarnex commented Feb 8, 2024

@v-klochkov

v-klochkov
v-klochkov approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to make a more targeted fix to disable only regressed cases, but Ok, let's revert it completely and I'll re-apply a smaller fix a bit later.

@ldrumm ldrumm merged commit d69a4c2 into sycl Feb 8, 2024
12 checks passed
@ldrumm ldrumm deleted the revert-12639-esimd_enable_atomic_update_cases branch February 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldrumm @sarnex @v-klochkov