[NFCI][SYCL] Introduce convertToOpenCLType helper #12674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably just the first patch in a series of refactoring PRs I'm envisioning. Ultimate goal is to align this helper and `sycl::detail::builtins::convert_arg` from `builtins_preview.hpp`, possible with the latter delegating to the former.
aelovikov-intel
commented
Feb 9, 2024
| #define __SYCL_EXTERN_IT3(Ret, prefix, call, Arg1, Arg2, Arg3) | ||
| #else | ||
| #define __FUNC_PREFIX_OCL sycl_host_ | ||
| #define __FUNC_PREFIX_CORE sycl_host_ | ||
| #define __SYCL_EXTERN_IT1(Ret, prefix, call, Arg) \ | ||
| #define __SYCL_EXTERN_IT1(Ret, prefix, call, arg) \ | ||
| using Arg = decltype(arg); \ |
There was a problem hiding this comment.
Had to move those aliases here to avoid "unused type alias" warning/error for device compilation.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Feb 12, 2024
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 12, 2024
Continuation of refactoring series initiated in intel#12674.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 12, 2024
Follow-up for intel#12674, updating places where `ConvertToOpenCLType_t` was used with a plain cast instead of `convertDataToType`. Not touching `multi_ptr` related uses just yet.
aelovikov-intel
added a commit
that referenced
this pull request
Feb 12, 2024
Continuation of refactoring series initiated in #12674.
aelovikov-intel
added a commit
that referenced
this pull request
Feb 13, 2024
Follow-up for #12674, updating places where `ConvertToOpenCLType_t` was used with a plain cast instead of `convertDataToType`. Not touching `multi_ptr` related uses just yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably just the first patch in a series of refactoring PRs I'm envisioning. Ultimate goal is to align this helper and
sycl::detail::builtins::convert_argfrombuiltins_preview.hpp, possibly with the latter delegating to the former.