Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Fix a bug with sycl::sample on marray types #12694

Merged
merged 2 commits into from
Feb 13, 2024
Merged

[SYCL] Fix a bug with sycl::sample on marray types #12694

merged 2 commits into from
Feb 13, 2024

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner February 12, 2024 22:05
steffenlarsen
steffenlarsen approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, but otherwise I think it looks good.

sycl/include/sycl/builtins_preview.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/builtins_preview.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/builtins_preview.hpp Outdated Show resolved Hide resolved
@aelovikov-intel aelovikov-intel merged commit 05740cc into intel:sycl Feb 13, 2024
11 checks passed
@aelovikov-intel aelovikov-intel deleted the upsample branch February 13, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelovikov-intel @steffenlarsen