[SYCL][Bindless] Add mipmap interop + slight redesign + bug fix #12736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Mipmap interop: - Remove "interop" image type as it is redundant for image creation - Add a vulkan mipmap interop test Slight redesign: - Simplify external resources Modify the bindless spec to reflect these changes Fix Vulkan interop tests to prevent memory leak issue by freeing mapped memory
Seanst98
force-pushed
the
sean/interop-mipmaps-redesign
branch
from
e43e356
to
761d8c1
Compare
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Seanst98
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
approved these changes
Feb 26, 2024
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Seanst98
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Friendly ping to @intel/unified-runtime-reviewers, @intel/llvm-reviewers-runtime, and @sergey-semenov reviews/approvals/merging. The CI failures appear to be unrelated to these changes. |
kbenzie
reviewed
Feb 29, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc
Outdated
Show resolved
Hide resolved
sergey-semenov
approved these changes
Feb 29, 2024
sergey-semenov
approved these changes
Feb 29, 2024
isaacault
approved these changes
Mar 1, 2024
DBDuncan
approved these changes
Mar 4, 2024
Seanst98
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Seanst98
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Seanst98
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kbenzie
reviewed
Mar 13, 2024
There was a problem hiding this comment.
oneapi-src/unified-runtime#1351 has been merged, please pull in the latest sycl branch changes, resolve the conflict, update the UR repo/tag as suggested.
Seanst98
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@intel/llvm-gatekeepers can we merge this please? |
martygrant
pushed a commit
that referenced
this pull request
Mar 14, 2024
…released (#12992) UR Part: oneapi-src/unified-runtime#1431 Depends on #12736 merging first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mipmap interop:
Slight redesign:
Modify the bindless spec to reflect these changes
Fix Vulkan interop tests to prevent memory leak issue by freeing mapped memory
Corresponding UR PR: oneapi-src/unified-runtime#1351
Depends on #12784 merging first