[SYCL] Don't set PI_USM_INDIRECT_ACCESS if platform don't support it #12780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the OpenCL platform doesn't support USM, don't set PI_USM_INDIRECT_ACCESS exec info. This will avoid SYCL program to fail when they don't use USM. If the program do need USM support, the runtime will fail on other API calls (like memory allocation). Signed-off-by: Victor Lomuller <victor@codeplay.com>
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
A few points:
|
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@steffenlarsen After discussion with Beni, I cut the link to the UR patch (will be caught with another bump). So if you are happy you can approve it, no risk to make it point to the wrong repo now :) |
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@intel/llvm-gatekeepers Ready to merge (failing CI job is unrelated and common to other PRs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the OpenCL platform doesn't support USM, don't set PI_USM_INDIRECT_ACCESS exec info. This will avoid SYCL program to fail when they don't use USM. If the program do need USM support, the runtime will fail on other API calls (like memory allocation).