[SYCL][Doc] Update free function queries extension #12792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pennycook
commented
Feb 21, 2024
Pennycook
commented
- Removes get_linear_id(), get_id() and get_item()
- Renames get_group() to get_work_group()
- Adds deprecated functionality section
- Renames this_kernel namespace to this_work_item
Update to latest extension template. Signed-off-by: John Pennycook <john.pennycook@intel.com>
The execution model of basic parallel_for makes it difficult to implement these in practice. Signed-off-by: John Pennycook <john.pennycook@intel.com>
We've had feedback that "group" being used to mean both a general concept (as in "a group of work-items") and a work-group specifically (as in "a sycl::group") is confusing. We can't completely fix that here, but can fix the new functions. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
These queries return objects associated with a particular work-item, not a particular kernel. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Signed-off-by: John Pennycook <john.pennycook@intel.com>
Previously suggested that this_item would be updated in the future, but we have no plans to update it for future versions of the SYCL specification. Signed-off-by: John Pennycook <john.pennycook@intel.com>
Pennycook
added
the
spec extension
gmlueck
reviewed
Feb 22, 2024
sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_queries.asciidoc
Show resolved
Hide resolved
gmlueck
approved these changes
Feb 22, 2024
|
@intel/llvm-gatekeepers I think this can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.