Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] vec<bfloat16> optimization fix #12794

Merged
merged 5 commits into from
Feb 28, 2024
Merged

[SYCL] vec<bfloat16> optimization fix #12794

merged 5 commits into from
Feb 28, 2024

Conversation

cperkinsintel
Copy link
Contributor

bfloat16 type reinterpretation may cause problems when aggressive optimizations are employed. Splitting them off to avoid this.

@cperkinsintel
bfloat16 type reinterpretation may cause problems when aggressive opt…
ae3f2c8 
…imizations are employed. Splitting them off to avoid this.
@cperkinsintel cperkinsintel marked this pull request as ready for review February 23, 2024 16:05
@cperkinsintel cperkinsintel requested review from a team as code owners February 23, 2024 16:05
@cperkinsintel
Copy link
Contributor Author

The failing win Assert tests are unrelated to this PR. Reported in #12797 and #12798

@cperkinsintel
Copy link
Contributor Author

ping to reviewers

bader
bader reviewed Feb 27, 2024
View reviewed changes
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/types.hpp Show resolved Hide resolved
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
bader
bader approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a minor style comment.

sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
@againull againull merged commit 9739ae5 into intel:sycl Feb 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bso-intel bso-intel bso-intel approved these changes

@bader bader bader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cperkinsintel @bader @bso-intel @againull